EternoSeeker / gameoflife

Conway's Game of Life
https://eternalgameoflife.netlify.app/
GNU General Public License v3.0
57 stars 108 forks source link

Adding a Logo #203 #307

Closed KomalSrivastava closed 2 months ago

KomalSrivastava commented 3 months ago

adding a logo

Description

it is a feature

Related Issue

https://github.com/EternoSeeker/gameoflife/issues/203#issuecomment-2168323554

Motivation and Context

How Has This Been Tested?

I have added logo in it..

203 is fixed

Checklist

Screenshots (if necessary):

Screenshot 2024-06-21 210901

netlify[bot] commented 3 months ago

Deploy Preview for eternalgameoflife ready!

Name Link
Latest commit af5a5df28cfb06cb6902fce18898ba26d53b7307
Latest deploy log https://app.netlify.com/sites/eternalgameoflife/deploys/66957fff269f130008660401
Deploy Preview https://deploy-preview-307--eternalgameoflife.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

KomalSrivastava commented 3 months ago

@EternoSeeker I have added a logo you can check my PR and please add gssoc label and level 2 in it so that it can be counted in the leaderboard.

EternoSeeker commented 3 months ago

can you make it PNG with bg transparent, it'll look better

KomalSrivastava commented 3 months ago

@EternoSeeker Screenshot 2024-06-22 111640

is this ok?

EternoSeeker commented 3 months ago

you've decreased opacity, I think. the text can be white to look good on dark background

KomalSrivastava commented 3 months ago

@EternoSeeker Screenshot 2024-06-22 194348

is this ok?

EternoSeeker commented 3 months ago

it's good but there is some problem with deploy preview. The sidebar width should be reduced

EternoSeeker commented 3 months ago

Screenshot 2024-06-22 213446 The logo isn't transparent for the other colors (maybe adding text there could work instead with the logo image), also the sidebar shouldn't be that close to the grid

EternoSeeker commented 2 months ago

hey there, you can add the logo to documentation for now. we can add it to the site later.

KomalSrivastava commented 2 months ago

@EternoSeeker ok Sir I'll add the logo to documentation for now. It will be done by tomorrow.

KomalSrivastava commented 2 months ago

@EternoSeeker I have kept the img=logo in GameLogo folder and resolved the conflict. Kindly merge my pull request and add GSSoC and level label in issue #203 and pull request #307

EternoSeeker commented 2 months ago

there are few code conflicts here. I think it would be better to create a new pr and simply put the logo in documentation

KomalSrivastava commented 2 months ago

@EternoSeeker I have added the logo in documentation named GameLogo.md. Conflict merged image