EternoSeeker / gameoflife

Conway's Game of Life
https://eternalgameoflife.netlify.app/
GNU General Public License v3.0
57 stars 108 forks source link

Overlap of button solved #318

Closed zalabhavy closed 3 months ago

zalabhavy commented 3 months ago

Description

Just added margins so button not overlap to other.

Related Issue

issue no #299

How Has This Been Tested?

Self testing

Checklist

Screenshots (if necessary):

image

netlify[bot] commented 3 months ago

Deploy Preview for eternalgameoflife ready!

Name Link
Latest commit e8f1870bcd05d0728cb2013c3bcef0576d71a148
Latest deploy log https://app.netlify.com/sites/eternalgameoflife/deploys/667b2e2f6366360008215d3a
Deploy Preview https://deploy-preview-318--eternalgameoflife.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zalabhavy commented 3 months ago

@EternoSeeker Please check it and merge !

EternoSeeker commented 3 months ago

why in px, use some relative unit

zalabhavy commented 3 months ago

@EternoSeeker What are you mean ? please explain i can't understand.

EternoSeeker commented 3 months ago

px is an absolute unit (always be the same size.). It would help if you preferred using relative units like rem, em, etc

zalabhavy commented 3 months ago

@EternoSeeker I have updated it with rem.

image

@EternoSeeker Thank you for sharing knowledge with me ! I have no idea about that difference.

partha120804 commented 3 months ago

Basically when you use px the size remains same on all screens, But when you use rem/em, the size changes with according to the screen size, so the button size depends relative to the size of device ( pc-big/tablet-medium/phone-small)

EternoSeeker commented 3 months ago

looks fine, thank you @zalabhavy