search

EternoSeeker / gameoflife

Conway's Game of Life
https://eternalgameoflife.netlify.app/
GNU General Public License v3.0
57 stars 108 forks source link

Modified the cursor #339

Closed Ramben0909 closed 2 months ago

Ramben0909 commented 3 months ago

Modified the cursor

I have updated the js for the cursor so that when it goes out the main-gird the color drop disappears

Motivation and Context

The change makes the game looks better it portrays that the cursor is active for gameplay on over the grid

How Has This Been Tested?

I have run the code on my system

Checklist

Screenshots (if necessary):

Screenshot 2024-07-02 182245

solved #319 hey @EternoSeeker please review it

netlify[bot] commented 3 months ago

Deploy Preview for eternalgameoflife ready!

Name Link
Latest commit 73cea190490f9c11ec12114a45af0c053f3e2419
Latest deploy log https://app.netlify.com/sites/eternalgameoflife/deploys/6683f86d723160000868e676
Deploy Preview https://deploy-preview-339--eternalgameoflife.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EternoSeeker commented 3 months ago

when cursor moves to the right half of the grid, it doesn't seem to show it

Ramben0909 commented 3 months ago

checking

Ramben0909 commented 3 months ago

I have solved this issue and added new pull request please check

EternoSeeker commented 2 months ago

there are some conflicts with the html file, please look into it

Ramben0909 commented 2 months ago

there are some conflicts with the html file, please look into it

the html conflicts are already there before doing any modifications of mine my code doesn't add any new conflicts it shows the same conflicts that exists already before adding any code of mine Screenshot 2024-07-07 232140 after adding code of mine

Screenshot 2024-07-07 232900

please review it the conflicts are not because of my code, and for which part is it showing I could not understand

EternoSeeker commented 2 months ago

no conflicts now, but please fix the cursor, it vanishes in the right half of the grid

Ramben0909 commented 2 months ago

no conflicts now, but please fix the cursor, it vanishes in the right half of the grid

check my 2nd commit there I have fixed this issue

EternoSeeker commented 2 months ago

It'll be safe to close this now.