Better Orbot integration - support other SOCKS proxies without requiring Orbot

[str4d]

orWall can be configured with a different SOCKS proxy, but it still requires Orbot to be installed. If orWall intends to support other SOCKS proxies, this hard dependency should be removed.

The Orbot dependency should only be checked when the firewall rules are set up, and should be dependent on a user-configured preference, ie. instead of just allowing the proxy port to be configured, the user should be allowed to choose either to proxy through Orbot, or through a manually-defined SOCKS proxy.

I use similar logic in Bote for allowing users to choose what I2P router to use - see https://github.com/i2p/i2p.i2p-bote.android/blob/master/app/src/main/java/i2p/bote/android/config/SettingsActivity.java#L210

This also simplifies the preferences UI - if they are using Orbot, then they will probably be using the default Orbot SOCKS port, so they don't need to see what port that is. You should be able to fetch the correct port from Orbot itself, using the NetCipher library (if it doesn't support that query, tell them to add it :P ).

[cjeanneret]

Nice feature request indeed. Will have a look at that and try to sort it for next Monday. No promises, but I'll try.

[cjeanneret]

Back again on this: for now, it seems netcipher doesn't provide any way to query Orbot dor its port configuration; In the meanwhile, I tried to include this lib in my project, but I'm struggling a bit (hey, first time for me ;)), so I've requested some support in order to get it sorted out.

Some proposal in order to get orWall recognize other SOCS providers:

• use netcipher to detect orbot, and propose the installation
• if no orbot, and first run: display a dialogue asking for user port configuration (after all, SOCKS or Transproxy aren't anything else than port, for iptables). May enter multiple ports.
• if orbot, query it about its default ports — and propose, in the settings, to add other ports for other services.

What do think about that?

[cjeanneret]

I guess orbot part will wait for this: https://dev.guardianproject.info/issues/3117