EthTx / ethtx

Python package with core transaction decoding functions.
https://www.ethtx.info
Apache License 2.0
453 stars 73 forks source link

Set config as global, update cache, refactor, add core #119

Open kchojn opened 2 years ago

kchojn commented 2 years ago
piotr-rudnik commented 2 years ago

So, global object for settings is not a good idea, but there is little we can do without changing more time, so it's ok. But I'm not sure about changing to pydantic settings model now, it's just by multiple people and everyone would need to upgrade their code to make it work with this. My proposition is to separate my pydantic settings model to another pull request, and merge it with another major version bump.

kchojn commented 2 years ago

You are right, major changes, will do it in 0.4.0 version