Ethaks / FVTT-Quench

Harden your Foundry module or system code with end-to-end UI tests directly within Foundry. Powered by Mocha and Chai.
https://ethaks.github.io/FVTT-Quench/index.html
GNU General Public License v3.0
28 stars 1 forks source link

Foundry v12 warning for using globalThis.mergeObject #545

Open CommanderTso opened 4 months ago

CommanderTso commented 4 months ago

Currently in v12, Quench gets depreciation warnings for using globalThis.mergeObject:

Error: You are accessing globalThis.mergeObject which must now be accessed via foundry.utils.mergeObject
Deprecated since Version 12
Backwards-compatible support will be removed in Version 14
    logCompatibilityWarning foundry-esm.js:4609
    get foundry-esm.js:66469
    get defaultOptions quench-results.ts:47
    Application foundry.js:5481
    QuenchResults quench-results.ts:37
    Quench quench.ts:111
    <anonymous> quench-init.ts:41

Repro steps:

nivthefox commented 1 week ago

Just a small bump and query: I can probably fix this with a pull request if you're interested in allowing another contributor aboard. I've been thoroughly enjoying using Quench for my modules and I'd hate to see it fall behind as Foundry progresses.

Ethaks commented 1 week ago

Just a small bump and query: I can probably fix this with a pull request if you're interested in allowing another contributor aboard. I've been thoroughly enjoying using Quench for my modules and I'd hate to see it fall behind as Foundry progresses.

@nivthefox No worries, Quench isn't falling behind anything. There's a v12 branch in this repo that contains an ApplicationV2 refactor of the UI amongst some other small stuff.