search

Ethan-Arrowood / harperdb-connect

Node.JS module for connecting to HarperDB and simplifying HTTP requests.
MIT License
6 stars 10 forks source link

Add expected assertions to unit tests #7

Closed Ethan-Arrowood closed 6 years ago

Ethan-Arrowood commented 6 years ago

https://facebook.github.io/jest/docs/en/expect.html#expectassertionsnumber

Trancever commented 6 years ago

Hello Ethan, i would like to work on it. I just have a question about implementation. Should I specify expected assertions in both synchronous and asynchronous tests or only in async ?

Ethan-Arrowood commented 6 years ago

Awesome! Start with asynchronous only for now. I’ll do a little more reading on what to do for synchronous only tests.

Trancever commented 6 years ago

Created pull request - #9 . Also found out a little mistake probably, more details in PR description.