search

Ethan3600 / magento2-CronjobManager

Cron Job Manager for Magento 2
https://packagist.org/packages/ethanyehuda/magento2-cronjobmanager
Open Software License 3.0
334 stars 72 forks source link

Timeline not working in Safari 12 #76

Open jeffwhitfield opened 5 years ago

jeffwhitfield commented 5 years ago

Just installed this extension for testing. So far, so good. :D However...

Appears the Timeline feature doesn't work in the latest versions of Safari on MacOS Mojave. Works great in Chrome though. In Safari, none of the bars show up...just the rows showing the name of the tasks followed by a grey bar. So...something is askew! :P

Ethan3600 commented 5 years ago

Hi @jeffwhitfield. Thanks for using the CJM

I'll admit, I did 100% of my development on Firefox.

Thanks for logging this bug!

jeffwhitfield commented 5 years ago

When I have time I’ll see what I can do to help fix it. :D

On Oct 16, 2018, at 7:28 AM, Ethan Yehuda notifications@github.com wrote:

Hi @jeffwhitfield. Thanks for using the CJM

I'll admit, I did 100% of my development on Firefox.

Thanks for logging this bug!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

schmengler commented 5 years ago

FWIW, on Chrome the graph did not load until I scroll down and then wait a few seconds

Ethan3600 commented 5 years ago

@schmengler ya it's a bug as a result of a fix for issue https://github.com/Ethan3600/magento2-CronjobManager/issues/50

Basically, we're removing elements (the cron "marks") from the DOM if a cron job's "mark" isn't within the view port (screen/timeline component) and adding them back if the condition is reversed. We're doing this for performance reasons. The check (to see if the "mark" is within the view port) gets triggered when you scroll around.

There's probably a cleaner solution for this, but I've been struggling with the aforementioned issue for a while. Luckily, it's not a show stopper :pray: and we did get a major performance boost when we push closer to 10k, even 20k crons on the timeline (which in theory shouldn't happen, but :man_shrugging: )

fredden commented 11 months ago

@jeffwhitfield I don't have access to Safari right now to test this. I wonder if the changes applied in #200 may have fixed this. Would you be able to test again with version 2.1.4 and report back?