EthanArbuckle / Apollo-CustomApiCredentials

Tweak to use your own reddit API credentials in Apollo
GNU General Public License v3.0
767 stars 139 forks source link

Can't change icon when sideloading #29

Open cam443 opened 1 year ago

cam443 commented 1 year ago

I'm not sure that this is specifically an issue with the tweak or just sideloading the app in general, but i'm unable to change the icon for the app. It says "Error Setting Icon. There was an issue setting the icon. If this persists contact the developer."

I'm not sure if this is something that could be fixed in this tweak, but it would be nice for us sideloaded users.

Unlearned6688 commented 1 year ago

Unless Christian (Apollo dev) fixes it (unlikely- don’t think he wants to be tied to circumventing reddit’s changes) the only thing you can do is hope someone else fixes it in-app, uploads .ipa with each possible icon or you use a program which allows for icon choice during the signing and installing process. Sideloadly allows it (but paywalled, slightly annoyingly), esign allows it (but then you need an Apple dev account or a UDID profile), probably some other programs allow it too. That’s the easiest way… just force it use an icon you want (it’s what I did via esign) or beg someone for an .ipa with the icon you want already setup

EthanArbuckle commented 1 year ago

Is Pro/Ultra enabled?

cam443 commented 1 year ago

Is Pro/Ultra enabled?

It is not, being that the app thinks it is in testflight mode and doesn't allow the activation to work. Though I believe changing the icons isn't tied to Pr/Ultra. Maybe it has something to do with the app activating testflight mode?

EthanArbuckle commented 1 year ago

i'm not sure if Pro/Ultra is actually required, but the app does check for it when the icon change is requested

Screen Shot 2023-07-09 at 11 18 07
cam443 commented 1 year ago

Might be due to some icons requiring pro/ultra?

Delta18-Git commented 1 year ago

Pro/Ultra is not supposed to be required with 1.15.11 but it doesn't work when sideloaded for some reason, am using TrollStore.

castdrian commented 3 months ago

This does not work generally with any app signed with a distribution certificate/unsigned with ts due to an App ID mismatch, it's not related to this application, if you wish to use Alternate App Icons with sideloaded apps you need to sign them using a local dev cert.

EthanArbuckle commented 3 months ago

@castdrian you have that problem with latest release? These keychain hooks were intended to address that issue (making the app's bundle ID not matter): https://github.com/EthanArbuckle/Apollo-CustomApiCredentials/blob/main/Tweak.m#L8-L30

castdrian commented 3 months ago

@castdrian you have that problem with latest release? These keychain hooks were intended to address that issue (making the app's bundle ID not matter): https://github.com/EthanArbuckle/Apollo-CustomApiCredentials/blob/main/Tweak.m#L8-L30

oh that's sick, I was unaware you can actually get this to work via hooks I tried your hooks on an orion tweak just then for funsies, but it would seem they don't work with orion, still very commendable to have found a way around it

castdrian commented 2 months ago

@castdrian you have that problem with latest release? These keychain hooks were intended to address that issue (making the app's bundle ID not matter): https://github.com/EthanArbuckle/Apollo-CustomApiCredentials/blob/main/Tweak.m#L8-L30

okay after extensive testing, those hooks do indeed not do anything to address this particular quirk in the apple ecosystem, truly unfortunate

EthanArbuckle commented 2 months ago

acknowledged, thanks for checking. i'm investigating and will push a fix