search

EthanC / Perplex

Discord Rich Presence implementation for Plex.
MIT License
86 stars 10 forks source link

Added full music capabilities + MusicBrainz API for metadata #4

Closed zane-schaffer closed 2 years ago

zane-schaffer commented 2 years ago

Was working on this last night - just realized you implemented in music stuff today!

Thought i'd put up a pr anyways since I added in a music metadata function grabbing from the free to use MusicBrainz API.

On my personal local fork, i added in the ability to use the MusicBrainz ID to grab album art from MusicBrainz database - ill clean that up and create a new pr for that as well.

EthanC commented 2 years ago

The reason for pushing "limited" music support was due to the lack of a reliable API; I'm not sure MusicBrainz fills this role either.

Looking through the response for the endpoint that you've provided in this PR, it doesn't appear to provide album art for the provided track. Metadata such as the title, artist, and album should be determined by the Plex library. Because of this, I can't see a reason to merge this and integrate MusicBrainz into the project at this time.

If I'm misunderstanding, let me know. I appreciate the PR regardless.