Closed EthanJamesLew closed 1 year ago
@EthanJamesLew Thank you for the fixes! I will merge into benchmarks branch. I have been running all benchmarks with grid opt and will now run for bopt to compare. For the mean_absolute_percentage_error, yes that is the behaviour one would expect, as y_true tends zero, the percentage errors tends to infinity. To deal with this, @KochdumperNiklas has added a clause to omit any y_true<0.01.
@Abdu-Hekal @KochdumperNiklas gents, this has been ruining the benchmarks real data script. When the sampling period was not provided,
auto_koopman
was not choosing a good (valid) sampling period. Also, bopt now uses the loglinear attributes, so it's better overall. Please merge/rebase onbenchmarks
branch.Also, is mean_absolute_percentage_error really what we want? I see the documentation says