search

EthanJamesLew / AutoKoopman

AutoKoopman - automated Koopman operator methods for data-driven dynamical systems analysis and control.
GNU General Public License v3.0
53 stars 10 forks source link

Fix Bad Sampling Periods in Hyperparameter Tuner #54

Closed EthanJamesLew closed 1 year ago

EthanJamesLew commented 1 year ago

From #52 , the hyperparameter tuner will use bad sampling periods when tuning against a re-sampled model. This patch corrects this. However, this is a result of counterintuitive interface design, and should likely be addressed by tweaking the class interfaces.

CC @Abdu-Hekal feel free to cherry-pick or merge. I ran it against your script for validation.

EthanJamesLew commented 1 year ago

@Abdu-Hekal I also cherry-picked the corrections from #45 to address #53. Please check that it works :)

EthanJamesLew commented 1 year ago

Passed CI/CD

Abdu-Hekal commented 1 year ago

@EthanJamesLew Merged and validated against systems with inputs and without. Thank you!