EthanRBrown / web-development-with-node-and-express

Companion repository to Web Development With Node and Express, first edition.
1.02k stars 501 forks source link

Duplicate ID on / views / contest / vacation-photo.handlebars #8

Open mchavezi opened 10 years ago

mchavezi commented 10 years ago

id="fieldName" is used twice. Shouldn't all IDs have unique names?

CervEdin commented 10 years ago

My guess is that the typo-monster has been around and that it's meant to be id="fieldEmail"

EthanRBrown commented 10 years ago

Hi, CervEdin, you're absolutely right, they should be unique, and that is probably the case. Did you find this in the repo or the book? If it's in the repo, could you provide the commit ID you found that in? If in the book, the chapter & section would be helpful.

mchavezi commented 10 years ago

In the printed book chapter 8, page 89, 91 and 93.

CervEdin commented 10 years ago

Chapter 8, p 136-7 commit aa53d7c0b042f564c5fe51d390306eace5ba790a

mchavezi commented 10 years ago

In the printed book chapter 8, page 89, 91 and 93.