EthanThatOneKid / acmcsuf.com

🐘 Official website of CSUF's ACM chapter
https://acmcsuf.com
MIT License
36 stars 45 forks source link

Update Quiz Page #1059

Closed 26samaahmed closed 2 months ago

26samaahmed commented 2 months ago

Fix #1052

Screenshot 2024-04-09 at 10 56 43 PM
netlify[bot] commented 2 months ago

Deploy Preview for acmcsuf ready!

Name Link
Latest commit 59c76e1ebb25556d0f421ac51321132498b2cdbd
Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/66342c3d6ba93500073a6481
Deploy Preview https://deploy-preview-1059--acmcsuf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JustinStitt commented 2 months ago

Your PR description says "Fix https://github.com/EthanThatOneKid/acmcsuf.com/issues/1052" but https://github.com/EthanThatOneKid/acmcsuf.com/issues/1052 mentions updating more than just the UI: We need to update the data along with doing a redesign to fit with the style of the rest of the website.

I think a bit more detail in your PR descriptions can help reviewers understand what is going on. With that being said, and with Ethan's review, you're on the right track 👍 🦖

26samaahmed commented 2 months ago

I have fixed the buttons on the results page as well as increase the gap between the team tile. I also noticed that the progress bar for some teams disappears on mobile so I increased the padding for the team tiles to be responsive.

Screenshot 2024-04-16 at 2 22 33 PM Screenshot 2024-04-16 at 2 30 30 PM

Screenshot 2024-04-16 at 2 21 38 PM Screenshot 2024-04-16 at 2 23 56 PM
karnikaavelumani commented 2 months ago

TODO

26samaahmed commented 2 months ago

For removing general, marketing, nodebuds, and special events team tiles from quiz results, the only way I was able to remove them is by deleting them from the teams.json since that's where we're getting the data from. Is there another way to remove them without affecting the rest of the website or modifying the teams.json file? @karnikaavelumani @EthanThatOneKid

26samaahmed commented 2 months ago

I removed the glow effect on hover and replaced it with a border color. I also changed the background color to be more readable and made the height fixed.

Screenshot 2024-04-29 230433

Screenshot 2024-04-29 230523

Screenshot 2024-04-29 231948