EthanThatOneKid / acmcsuf.com

🐘 Official website of CSUF's ACM chapter
https://acmcsuf.com
MIT License
38 stars 46 forks source link

Fix website redesign hero.svelte #938

Closed karnikaavelumani closed 10 months ago

karnikaavelumani commented 10 months ago

The hero component had a couple errors so this PR is to fix those.

Changes

Screenshots

image image image

netlify[bot] commented 10 months ago

Deploy Preview for acmcsuf ready!

Name Link
Latest commit 58a51cf2e91af45d434f5d5d7a0211e1eaa22cb4
Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/653368af7475770007c22288
Deploy Preview https://deploy-preview-938--acmcsuf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

karnikaavelumani commented 10 months ago

@EthanThatOneKid Can you properly check and see if the CSS is appropriately adjusting to all screen sizes? In comparison to the other components, I am noticing the behavior of the hero.svelte page is different from the others.

@tomasohCHOM I noticed why the multicolor text was not working originally. The color spans across the entire screen in tablet mode so we need to add a width to fix it. However, I could not center it properly. I added you for review if you would like to take a crack at it!

tomasohCHOM commented 10 months ago

@karnikaavelumani I will take a look at it right now and tell you how it goes!