EthanYidong / pe

0 stars 0 forks source link

App deletes note when &@ is in filename #10

Open EthanYidong opened 1 year ago

EthanYidong commented 1 year ago

Steps to Reproduce

  1. Create a file with &@ inside the name
  2. Add the file
  3. Close and relaunch the app

Expected

Nothing of note happens, app launches correctly

Actual

App states that save was corrupted and clears it

Screenshot 2023-04-14 at 5.09.08 PM.png

Severity

It may be unlikely that the user has notes with &@ in the name but it is not out of the question, and if they do they will be frustrated that they cannot add it in.

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

saved file deleted

image.png

saved file &@ 'gee'.txt was deleted upon exit and reopening of app, citing corruption


[original: nus-cs2113-AY2223S2/pe-interim#1702] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is the expected behavior. The use of &@ in the file name corrupts data file. Therefore when starting CLIAlgo it is treated as a corrupted entry and erased.

image.png

However we did not mention this in the UG therefore we accept this bug. However, we feel that the severity should be low because this flaw only affects files that contains &@ and the user can still use the application normally otherwise.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]