Ethck / azgaar-foundry

Unofficial Azgaar's Fantasy Map Generator Import
MIT License
43 stars 15 forks source link

Link to city map not being generated correctly #31

Closed Eldhelion closed 4 months ago

Eldhelion commented 2 years ago

Foundry Version 10 - Build 288 module version 0.3.1

The link inside the burgs journal is incomplete/wrong so that it always generate a coastal city

for Reference, link in the journal https://watabou.github.io/city-generator/?&citadel=1&walls=1&seed=3392497470474&name=Geth&population=1645&gates=-1 when you open it, you're redirected to https://watabou.github.io/city-generator/?size=15&seed=3392497470474&name=Geth&population=1645&greens=0&farms=1&citadel=1&urban_castle=0&plaza=1&temple=1&walls=1&shantytown=0&coast=1&river=0&gates=-1&sea=0 image

link in the azgaar site https://watabou.github.io/city-generator/?name=Geth&population=1645&size=16&seed=3392497470474&river=0&coast=0&farms=0&citadel=1&urban_castle=1&hub=false&plaza=0&temple=0&walls=1&shantytown=0&gates=-1

image

Ethck commented 2 years ago

As much as I would love to solve this, it would require an extensive amount of work to replicate how it is done in FMG.

If anyone is curious, it's described here: https://github.com/Azgaar/Fantasy-Map-Generator/blob/a617dda3ad7dbc50aee384a1d0e0bd3a2f98035b/modules/ui/editors.js#L298

The main issue revolves around a LOT of missing functions and global variables that are incredibly difficult to recreate with my lack of knowledge on this part. I've updated to include support for the urban_castle parameter and the coast parameter so hopefully that will make it at least slightly better. I'll leave this issue open, however.

Ethck commented 4 months ago

Fixed as of today.