search

EtheaDev / SVGIconImageList

Three engines to render SVG (Delphi Image32, Skia4Delphi, Direct2D wrapper) and four components to simplify use of SVG images (resize, fixedcolor, grayscale...)
Apache License 2.0
321 stars 93 forks source link

Missing line in TSVGIconImageListEditor.UpdateGUI #153

Closed Lajos-Juhasz closed 3 years ago

Lajos-Juhasz commented 3 years ago

I still have no local repository to send a pull request for this one. When there is no image selected the Category is enabled and trying to exit it results in Access Violation. It should be adjusted same as NameEdit:

CategoryEdit.Enabled:= LIsItemSelected;

carloBarazzetta commented 3 years ago

I cannot reproduce the problem: when there isn't any category the "All" item is always present... Can you explain me the steps to reproduce the error?

Lajos-Juhasz commented 3 years ago

Place a new TSVGIconImageCollection on the form. Double click it to invoke the component editor. Focus the CategoryEdit enter some value and try to click on another component in the TSVGIconImageListEditor.CategoryEditExit the SelectedIcon = nil this will cause access violation on the line:

if SelectedIcon.Category <> CategoryEdit.Text then

carloBarazzetta commented 3 years ago

Fixed in 2.2.2 version