search

EtheaDev / SVGIconImageList

Three engines to render SVG (Delphi Image32, Skia4Delphi, Direct2D wrapper) and four components to simplify use of SVG images (resize, fixedcolor, grayscale...)
Apache License 2.0
321 stars 93 forks source link

Benchmark Demo #181

Closed AngusJohnson closed 3 years ago

AngusJohnson commented 3 years ago

Hi again carlo.

There's a bug in the demo (at line 121 of UBenchmark.pas) that causes quite a problem for Image32's benchmark when DrawVisible is unchecked:

        LBitmap.Width := SvgIconImage.Height;
        LBitmap.Width := SvgIconImage.Width;

should be changed to ...

        LBitmap.Height := SvgIconImage.Height;
        LBitmap.Width := SvgIconImage.Width;

Also, any of the icon sets with blurring (eg Papirus-icons) shouldn't really be benchmarked since only Image32 will blur (which is always slow). Finally, I hope all benchmarking is done in Release mode because Image32 will be much slower when in Debug mode (when all inlining is disabled).

Cheers

carloBarazzetta commented 3 years ago

I'll fix it. I've changed the comment about performances in readme and wiki-pages explaining the "slow" performance rendering papirus icons.

luebbe commented 3 years ago

I already submitted a PR