Blueish tint on MacOS-X reappeared (Android is OK)

EtheaDev / SVGIconImageList

Three engines to render SVG (Delphi Image32, Skia4Delphi, Direct2D wrapper) and four components to simplify use of SVG images (resize, fixedcolor, grayscale...)

Apache License 2.0

321 stars 93 forks source link

Blueish tint on MacOS-X reappeared (Android is OK) #233

Closed birbilis closed 2 years ago

birbilis commented 2 years ago

After installing latest SVGIconImageList from GetIt, had to patch the OS-X version again to fix reintroduced blueish tint (Android was fine this time)

Strange is I had to undo for OS-X the fix I had done to Image32 - probably something else changed there in between that made that fix not working anymore. Added some comments at the end of the original Blueish tint issue on what I changed, but can also see the commit/pull request

The above images are with the two fixed files as committed at https://github.com/EtheaDev/SVGIconImageList/commit/853f5f6da35217335322196352dbcdfbad5bdffe

Did a pull request

birbilis commented 2 years ago

note that I did make sure the FixedColor function also works ok with the above fixes

birbilis commented 2 years ago

comment for testers:

if you add OS-X platform to the SVGIconImageListDemoFMX project see https://github.com/EtheaDev/SVGIconImageList/issues/232
for Android you may also need to right click Libraries under Android target and do "Revert System Files to Default"

birbilis commented 2 years ago

also note I can only try on Intel-based MacOS-X, not ARM one (hope that doesn't behave differently)

birbilis commented 2 years ago

closing this issue in favor of the reopened issue https://github.com/EtheaDev/SVGIconImageList/issues/229 since it was working on Android via a series of swaps that weren't needed (and Image32 had issue underneath on Android)