EtherealEmil / UsualScrap

A lethal company mod
https://thunderstore.io/c/lethal-company/p/etherealemil/UsualScrap/
MIT License
1 stars 0 forks source link

Gift wrap Invisible presents #5

Closed WULFXP closed 5 months ago

WULFXP commented 6 months ago

Playing in multiplayer with friends, I am the host my friends are saying after using the gift wrap they're seeing presents that aren't there for me. Thank you :D

EtherealEmil commented 6 months ago

Are your friends using the gift wrap or are you? And are you the only one who doesn't see it? This should hopefully be an easy fix as I already have some ideas about what's happening.

Teacyn commented 6 months ago

Can confirm the same here. If I unwrap a present that I gift wrapped, other players can still see the present.

EtherealEmil commented 6 months ago

OH ok, I didn't quite understand the issue the first time but I do now. While I'll try to fix the issue, the version I have has a bunch of code changes but I haven't released it yet, if the issue is still present with the next update I release I will then focus on fixing it.

EtherealEmil commented 5 months ago

The new update is out. If you experience that bug using the wishlist that replaced the giftwrap please post it here, If all is quiet and good I will close this issue in a week or so.

Teacyn commented 5 months ago

While this bug is fixed, a new bug has arrived where it now creates three gift boxes that other players can't see. Two of them can be picked up, meaning you now get a duplicate scrap (the two tanks here). The third is completely uninteractive and is only visible to the person who used the wishlist. It also tends to spawn an extra non-interactive wishlist. The wishlist seems to just not sync properly at all.

image

Edit: It seems like in some cases this can cause an infinite item duplication glitch, as the wishlist doesn't get consumed. This resulted in us having over 200 scrap items on a moon. image

Edit 2: It seems to also be able to cause the throw items glitch when picked up, a player in our session softlocked multiple times.

Edit 3: You can wishlist a wishlist.

EtherealEmil commented 5 months ago

Alright, I'll see if I can fix it but I may just disable it and come back to it later. Getting kind of annoyed of it having issues. Sorry about that.