search

EthereumCommonwealth / Auditing

Ethereum Commonwealth Security Department conducted over 400 security audits since 2018. Not even a single contract that we audited was hacked. You can access our audit reports in the ISSUES of this repo. We are accepting new audit requests.
https://audits.callisto.network/
GNU General Public License v3.0
131 stars 34 forks source link

Holo Token (HOT) #268

Closed yuriy77k closed 5 years ago

yuriy77k commented 5 years ago

Audit request

Audit Top 200 CoinMarketCap tokens.

Holo (HOT)

https://holochain.org/

Deployed at https://etherscan.io/address/0x6c6ee5e31d828de241282b9606c8e98ea48526e2#contracts

Source code

https://etherscan.io/address/0x6c6ee5e31d828de241282b9606c8e98ea48526e2#contracts

Disclosure policy

public

Platform

ETH

Number of lines:

142

MrCrambo commented 5 years ago

Auditing time 1 day

yuriy77k commented 5 years ago

@MrCrambo assigned

danbogd commented 5 years ago

Auditing time: 1 day.

RideSolo commented 5 years ago

Auditing time 1 day

danbogd commented 5 years ago

My report is finished.

yuriy77k commented 5 years ago

@danbogd @RideSolo assigned

yuriy77k commented 5 years ago

Holo Token Security Audit Report

1. Summary

Holo Token smart contract security audit report performed by Callisto Security Audit Department

2. In scope

  1. https://etherscan.io/address/0x6c6ee5e31d828de241282b9606c8e98ea48526e2#contracts

3. Findings

In total, 3 issues were reported including:

No critical security issues were found.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add the following code to the transfer(_to address, ...) function:

require( _to != address(this) );

3.2. Zero address checking

Severity: low

Description

There are no zero address checking in functions setMinter at line 239, setDestroyer at line 269 and mint at line 243.

3.3. Owner privileges

Severity: owner privileges

Description

Owner can mint any amount of tokens and for a long period of time, because he can not finish minting and can set himself as minter.

4. Conclusion

The audited smart contract can be deployed. Only low severity issues were found during the audit.

5. Revealing audit reports

https://gist.github.com/yuriy77k/c6a8d409a858f6155780ea7f4addd097

https://gist.github.com/yuriy77k/dcea1e26ba3e6e73e5e51a77e5d241d3

https://gist.github.com/yuriy77k/4afef9710e08a8a9030e58c8590019b6

MillianoConti commented 5 years ago

Announced:https://www.reddit.com/r/holochain/comments/c2wd6k/audit_of_holo_token_hot_performed_by_callisto/