Closed carlossampol closed 5 years ago
Auditing time: ~ 3 days.
@danbogd assigned
Estimated auditing time is 3 days.
@gorbunovperm assigned
My report is finished.
My report is finished.
How can I obtain the report?
The frontend is a bit more polished, there is also a barebones relayer ready and would like to deploy this to the mainnet with an audit from the Eth commonwealth if possible hahahaha
@kendricktan Our audit procedure requires three auditors to review the contract. Currently two reports are completed. We are waiting for one more auditor and we will publish the summary as soon as the third auditor completes his report.
Thanks for the update!
Auditing time 2 days
@MrCrambo assigned
My report is finished
Heiswap Dapp smart contract security audit report performed by Callisto Security Audit Department
Heiswap (黑 swap) is an Ethereum transaction mixer that ultilizes parts of CryptoNote to enable zero-knowledge transactions. It ulitilizes Ring Signatures and pseudo-stealth addresses to achieve its zero-knowledge properties. The deployed smart contract handles the signature verification, while the client is responsible for generating the pseudo-stealth address. Ring signatures was only possible on the EVM (gas-wise) due to the recent addition of EIP198.
Description: https://kndrck.co/posts/introducing_heiswap/
Dapp: https://heiswap.exchange/
Commit hash: afd1a2731bdcaea03698e29ee179b0b29b536807
In total, 5 issues were reported including:
1 high severity issues.
2 medium severity issues.
1 low severity issues.
1 minor observation (not security issue)
Confidentiality is based on the fact that there is no links between 5(maximum) deposits and 5 withdrawals. But the contract provides for the premature closure of the ring, even if the amount of participants is less than 5. The exposer can intentionally enter each ring together with the observed address and close the ring with two participants. Thus, he will be able to detect the withdrawing address.
To have only two participants in the ring, the exposer can track the transaction of the observed address and as soon as it appeared to make an Front-Running Attack closing the previous ring. Then the observed address will come into a new ring, which the exposer will be able to close with 2 participants.
When the deposit is not an exact value, rounding occurs. And a decimal fraction of deposit remains blocked in the contract. For example, if an amount of 2.7ETH is deposited , 0.7ETH will be lost.
Return the rest of the rounding.
The contract provides for compensation of gas during the withdrawal of funds:
// Send ETH to receiver
// Calculate fees (1.33%) + gasUsage fees
uint256 gasUsed = startGas - gasleft();
uint256 fees = (withdrawEther / 75) + gasUsed + startGas;
But gasleft()
function returns just the amount of gas(not in wei
). These calculations do not take into account the gas price. Therefore, the returned funds will be incomparably less than spent.
In function withdraw
there is no zero address checking.
blocksPassed
variable is not used.
The audited smart contract must not be deployed. Reported issues must be fixed prior to the usage of this contract.
https://gist.github.com/yuriy77k/5ae25c2c0892dd524007429135c27c1a
https://gist.github.com/yuriy77k/573a83e8a78142ab86a0f9e6cbfea71d
https://gist.github.com/yuriy77k/3090239037c165b8fc2371e24ee509f5
Audit request
Heiswap (黑 swap) is an Ethereum transaction mixer that ultilizes parts of CryptoNote to enable zero-knowledge transactions.
It ulitilizes Ring Signatures and pseudo-stealth addresses to achieve its zero-knowledge properties. The deployed smart contract handles the signature verification, while the client is responsible for generating the pseudo-stealth address.
Ring signatures was only possible on the EVM (gas-wise) due to the recent addition of EIP198.
Deployed at https://ropsten.etherscan.io/address/0xbbbf35a4485992520557ae729e21ba35aab178d7
https://kndrck.co/posts/introducing_heiswap/
Source code
https://github.com/kendricktan/heiswap-dapp/tree/master/contracts
Exclude: Migrations.sol
Disclosure policy
public
Platform
Ethereum
Number of lines:
403