EthereumCommonwealth / Auditing

Ethereum Commonwealth Security Department conducted over 400 security audits since 2018. Not even a single contract that we audited was hacked. You can access our audit reports in the ISSUES of this repo. We are accepting new audit requests.
https://audits.callisto.network/
GNU General Public License v3.0
131 stars 34 forks source link

Scanetchain #377

Closed carlossampol closed 5 years ago

carlossampol commented 5 years ago

Audit request

It's only ERC-20 Token to trading and utility of platform.

Source code

https://github.com/Scanetchain/Scanetchain-ERC20-Token/blob/master/Contracts/scanetchaintoken_new_final.sol

Disclosure policy

andy@kchain.kr

Platform

Ethereum

Number of lines:

238

MrCrambo commented 5 years ago

Auditing time is 1 day

yuriy77k commented 5 years ago

@MrCrambo assigned

MrCrambo commented 5 years ago

My report is finished

danbogd commented 5 years ago

Auditing time: 2 days.

danbogd commented 5 years ago

My report is finished.

yuriy77k commented 5 years ago

@danbogd assigned

RideSolo commented 5 years ago

Auditing time 1 day

yuriy77k commented 5 years ago

Scanetchain Security Audit Report

1. Summary

Scanetchain smart contract security audit report performed by Callisto Security Audit Department

Symbol       : SWC
Name         : Scanetchain
Capped supply: 1,000,000,000
Decimals     : 18 
Standard     : ERC20

2. In scope

3. Findings

In total, 2 issues were reported including:

No critical security issues were found.

3.1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  1. It is possible to double withdrawal attack. More details here.

  2. Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here.

Recommendation

Add the following code to the transfer(_to address, ...) function:

require( _to != address(this) );

3.2. Owner Privileges

Severity: owner privileges

Description

Owner has the right to pause/unpause token transfers and approvals.

Code snippet

https://github.com/Scanetchain/Scanetchain-ERC20-Token/blob/master/Contracts/scanetchaintoken_new_final.sol#L374#L431

4. Conclusion

The audited smart contract can be deployed. Only low severity issues were found during the audit.

5. Revealing audit reports

https://gist.github.com/yuriy77k/24591a9f365f748d5451cdca94e1b3d7

https://gist.github.com/yuriy77k/3c2a92be22a3f0f1dada3b11e097c03f

https://gist.github.com/yuriy77k/2a199bc40fe873589b58155639a8e445