yuriy77k
commented
3 years ago MChef Security Audit Report v.2
1. Summary
MChef smart contract security audit report performed by Callisto Security Audit Department
2. In scope
Contract commit c45a40dd4c470547679a8f051234e3a912245b2a
3. Findings
In total, 1 issues were reported including:
-
0 high severity issues.
-
0 medium severity issues.
-
0 low severity issues.
-
1 notes.
No critical security issues were found.
3.1. High Gas spending
Severity: note
Description
The function massUpdatePools() updates every existing pool. It will use many gas if will be many pools. This function is calling from others functions: add(), set() (it's possible not update pools from them), updateRewardPerBlock(), setRewardsValue(), updateRewardsValue(), so Gas usage will be high i those functions too.
However, using massUpdatePools() in the functions setRewardsValue(), updateRewardsValue() is not required and may be removed from them.
4. Conclusion
The audited smart contract can be deployed. The issues pointed in the previous report are fixed.
Audit request
Source code
https://github.com/GoSwapp/liquiditymining/blob/main/contract
Disclosure policy
In case of issues provide the report privately
Standard disclosure policy.
Contact information (optional)
... Provide information to contact you or the smart contract-developer in case high severity issues will be found ...
... Provide information about the media resources of the project you want us to audit (website/ twitter account/ reddit/ telegram channel/ etc.) ...
Platform
ETH