EthereumCommonwealth / Auditing

Ethereum Commonwealth Security Department conducted over 400 security audits since 2018. Not even a single contract that we audited was hacked. You can access our audit reports in the ISSUES of this repo. We are accepting new audit requests.
https://audits.callisto.network/
GNU General Public License v3.0
132 stars 34 forks source link

Monsta Infinite Inception #561

Closed jackgoh closed 3 years ago

jackgoh commented 3 years ago

Audit request

... Briefly describe your smart-contract and its main purposes here ... A presale contract to adopt monsta by investor or giveaway monsta by owner. Redeem monsta NFT will be done in another contract (not in this contract audit)

Source code

... Give a link to the source code of contracts ... https://gitlab.com/monsta-infinite/moni-smart-contracts

Disclosure policy

... Do you want us to publish the report as it is or to notify you privately in case of finding critical mistakes? ...

... provide your conditions for publishing the report or leave only standard disclosure policy link ... Do not publish the report, notify us privately in case of finding critical mistakes until those mistakes has been resolved. Standard disclosure policy.

Contact information (optional)

... Provide information to contact you or the smart contract-developer in case high severity issues will be found ... email : dev@monstainfinite.com telegram: @jackg0h

Platform

... In which network will your contract be deployed? (EOS/TRX/ETC/ETH/CLO/UBQ/something else ) ...

Binance Smart Chain

yuriy77k commented 3 years ago

@jackgoh The audit fee with the highest priority is 1123 USDT. You may send USDT (ERC20 or BEP20) to: 0xb9662e592f2f0412be62f0833ca463a9b1aabebb or USDT (TRC20) to: TBzUKbek9AYVBwf91ykh3KY4Ushk95SCiB

The estimated auditing time - 1 day after payment.

jackgoh commented 3 years ago

@yuriy77k Payment is done

yuriy77k commented 3 years ago

The report was sent by telegram.

yuriy77k commented 3 years ago

Monsta Infinite Inception Security Audit Report

1. Summary

Monsta Infinite Inception smart contract security audit report performed by Callisto Security Audit Department

The presale contract accepts payment in BNB from users to adopt Monsta and allow a redemption contract (out of scope of this audit) to redeem Monsta to users.

Contract owner has right to adopt Monsta to any users without payment and limits.

Contract itself does not mint any tokens or other kind of Monsta.

2. In scope

Commit 3303268d5456d51a5f7412be8cfca7e3caf73ed5

3. Findings

In total, 0 issues were reported, including:

In total, 5 notes were reported, including:

3.1. Owner privileges

Severity: owner privileges

Description

Contract owner has rights:

  1. Transfer all BNB held by the contract to the owner using function reclaimBNB.
  2. Giveaway Monsta without effecting adopted Monsta counter to any addresses without payment.
  3. Pause/unpause MonstaPresale contract.
  4. Set redemption contract address

3.2. Contract logic is not completed

Severity: note

Description

There is a function redeemAdoptedMonsta that can be called from redemption contract only, but there is not code of this contract in the provided repository. So entire logic of this function is not clear.

4. Security practices

5. Conclusion

The audited smart contract can be deployed. No security issues were found in the audited contracts. Pay attention, the redemption contract was not included in the audit and its logic is unknown.

It is recommended to adhere to the security practices described in pt. 4 of this report to ensure the contract's operability and prevent any issues that are not directly related to the code of this smart contract.

jackgoh commented 3 years ago

@yuriy77k Requesting re-audit contract with new functions at https://gitlab.com/monsta-infinite/moni-smart-contracts master branch

yuriy77k commented 3 years ago

@jackgoh the re-audit will cost 280 USDT

jackgoh commented 3 years ago

@yuriy77k payment done

yuriy77k commented 3 years ago

Monsta Infinite Inception v.2 Security Audit Report

1. Summary

Monsta Infinite Inception smart contract security audit report performed by Callisto Security Audit Department

The presale contract accepts payment in BNB from users to adopt Monsta and allow a redemption contract (out of scope of this audit) to redeem Monsta to users.

Contract owner has right to adopt Monsta to any users without payment and limits.

Contract itself does not mint any tokens or other kind of Monsta.

2. In scope

Commit 9444519ea81a6b29d78e8b34868ed4e60f38de03

3. Findings

In total, 0 issues were reported, including:

In total, 5 notes were reported, including:

3.1. Owner privileges

Severity: owner privileges

Description

Contract owner has rights:

  1. Transfer all BNB or ERC20 tokens held by the contract to the owner using function reclaimBNB and reclaimBEP20.
  2. Giveaway Monsta without effecting adopted Monsta counter to any addresses without payment.
  3. Pause/unpause MonstaPresale contract.
  4. Set redemption contract address.
  5. Add/remove user to/from whitelist using function setWhitelist.
  6. Enable/Disable whitelist checking.

3.2. Contract logic is not completed

Severity: note

Description

There is a function redeemAdoptedMonsta that can be called from redemption contract only, but there is not code of this contract in the provided repository. So entire logic of this function is not clear.

4. Security practices

5. Conclusion

The audited smart contract can be deployed. No security issues were found in the audited contracts. Pay attention, the redemption contract was not included in the audit and its logic is unknown.

It is recommended to adhere to the security practices described in pt. 4 of this report to ensure the contract's operability and prevent any issues that are not directly related to the code of this smart contract.

yuriy77k commented 3 years ago

Please find below the links of the blog post and our twitter publications:

Blog post: https://callisto.network/monsta-infinite-inception-security-audit/ Twitter: https://twitter.com/Callisto_Audits/status/1431286477691002882

Twitter FR: https://twitter.com/CallistoNetFr/status/1431286469692436487

Twitter RU: https://twitter.com/CallistoNetRu/status/1431286461756813313