EthereumCommonwealth / etherwallet

Ethereum Classic blockchain interaction web tool.
https://ethereumproject.github.io/etherwallet/
BSD 4-Clause "Original" or "Old" License
14 stars 17 forks source link

Use Pirl's official HD Derivation Path "m/44'/164'/0'/0" #203

Closed mkrufky closed 6 years ago

mkrufky commented 6 years ago

Use Pirl's official HD Derivation Path "m/44'/164'/0'/0"

Support for full 32bit Chain IDs has been merged into LedgerHQ/blue-app-eth:

https://github.com/LedgerHQ/blue-app-eth/commit/8260268b0214810872dabd154b476f5bb859aac0 https://github.com/LedgerHQ/blue-app-eth/commit/74c085ca2d032179fcf205cda1dee38c92877933

The signature V component must be recalculated in the javascript. A pull request for this new feature is here:

https://github.com/EthereumCommonwealth/etherwallet/pull/202

This change does not depend on any of the above - it merely sets the correct HD Derivation path in ClassicEtherWallet, along with the required UI changes in the HD Derivation dialog box.

With all changes applied, the Ledger Nano S can be used with ClassicEtherWallet to safely sign transactions with EIP-155 correctly enabled.

cc: @masterdubs