search

EthicalSource / hippocratic-license-3

An ethical license for open source.
https://firstdonoharm.dev/
Other
33 stars 5 forks source link

fix: prevent builder sidebar from overflowing page #45

Closed theonesean closed 2 years ago

theonesean commented 2 years ago

Closes #44.

Using @nilsnh's suggested styling, as well as some other tweaks, this allows the builder sidebar to vertically scroll in situations where it otherwise would be cut off. It also tightens up some vertical spacing elsewhere in the builder.

My only concern is that there's, like, a lot of places where the page scrolls: the list of modules, the builder itself, and the whole license/page. I think it's a non-issue for right now, or at least a nitpicky one. But I did have the thought while building.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for hl3 ready!

🔨 Explore the source changes: 24ca0b7363f65c0b6ecd730ad1b0825f55625708

🔍 Inspect the deploy log: https://app.netlify.com/sites/hl3/deploys/622bdc8e4d88b600086f2248

😎 Browse the preview: https://deploy-preview-45--hl3.netlify.app

CoralineAda commented 2 years ago

My only concern is that there's, like, a lot of places where the page scrolls: the list of modules, the builder itself, and the whole license/page. I think it's a non-issue for right now, or at least a nitpicky one. But I did have the thought while building.

We could look at a different treatment for the sidebar, but I think this is great for now. Thanks!