EthicalSource / hippocratic-license-3

An ethical license for open source.
https://firstdonoharm.dev/
Other
33 stars 5 forks source link

:UP: upgrade to latest Node LTS #57

Closed nilsnh closed 2 years ago

nilsnh commented 2 years ago

Fixes #55 .

Milestone

Stop being locked to Node v14, and just start tracking the latest Node LTS release.

Getting there

  1. Use NVM configuration syntax to select latest Node LTS release.
  2. Removing NPM config so that it will track the LTS Node version.
  3. Removing Netlify function version specification so that it will just use latest LTS release.
  4. Also, I saw some warnings in the Netlify build log related to esbuild for function bundling which is beta functionality. I tried to fix it but eventually gave up and removed it from the build step. Esbuild didn't really provide us with any needed functionality there. See: https://github.com/EthicalSource/hippocratic-license-3/pull/57/commits/31cb93cafe1c291ad0f08c9e7084105f0927fb43

Interesting bits

What I need help with

What's next

After merging, this PR should allow us to:

netlify[bot] commented 2 years ago

Deploy Preview for firstdonoharm ready!

Name Link
Latest commit 31cb93cafe1c291ad0f08c9e7084105f0927fb43
Latest deploy log https://app.netlify.com/sites/firstdonoharm/deploys/62d586634d01b400089965ea
Deploy Preview https://deploy-preview-57--firstdonoharm.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.