search

Ethiel97 / nice_intro

Get your users to know your app with ease
MIT License
25 stars 8 forks source link

Examples need updating #1

Closed johnareid54 closed 4 years ago

johnareid54 commented 4 years ago

I have just tried to load the example version and had the following problem:

I think this is because you have not updated the example code.

Also if I put in the device into landscape mode the layout is distorted. Do you have any plans to improve the landscape layout?

Ethiel97 commented 4 years ago

Hello buddy,

Thanks for the feedback. I'll update the example file and handle the landscape mode.

Did you read the doc of the package?

Cheers, Ethiel ADIASSA.

Consultant Développeur informatique (Fullstack Web et Mobile)

On Mon, Apr 27, 2020, 11:08 AM johnareid54 notifications@github.com wrote:

I have just tried to load the example version and had the following problem:

  • The parameter 'onSkip' is required. .
  • The parameter 'onDone' is required. .

I think this is because you have not updated the example code.

Also if I put in the device into landscape mode the layout is distorted. Do you have any plans to improve the landscape layout?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ethiel97/nice_intro/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBHGHIEFZ55T2SNYPYWDJLROVRSXANCNFSM4MR2MCBA .

johnareid54 commented 4 years ago

Did you read the doc of the package?

Like most computer guys I quickly glanced at the docs, I just wanted to paste in your example and see what it looked like on a device. I first tried the example in pub.dev but the two imports were not found: import 'package:intro_screen/intro_screens.dart'; import 'package:intro_screen/page_view_model.dart';

Thanks for looking into the landscape issue, I always regard the end-users as being totally stupid and doing things you least expect.

Ethiel97 commented 4 years ago

Yes you are right. Let me update the doc.

Consultant Développeur informatique (Fullstack Web et Mobile)

On Mon, Apr 27, 2020, 11:38 AM johnareid54 notifications@github.com wrote:

Did you read the doc of the package?

Like most computer guys I quickly glanced at the docs, I just wanted to paste in your example and see what it looked like on a device. I first tried the example in pub.dev but the two imports were not found: import 'package:intro_screen/intro_screens.dart'; import 'package:intro_screen/page_view_model.dart';

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ethiel97/nice_intro/issues/1#issuecomment-619926939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBHGHOPIPBXAOW75LHSCMTROVVDNANCNFSM4MR2MCBA .

Ethiel97 commented 4 years ago

The package is updated. You can check again. Thanks for your useful feedback.

Cheers, Ethiel.

Consultant Développeur informatique (Fullstack Web et Mobile)

On Mon, Apr 27, 2020, 11:38 AM johnareid54 notifications@github.com wrote:

Did you read the doc of the package?

Like most computer guys I quickly glanced at the docs, I just wanted to paste in your example and see what it looked like on a device. I first tried the example in pub.dev but the two imports were not found: import 'package:intro_screen/intro_screens.dart'; import 'package:intro_screen/page_view_model.dart';

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ethiel97/nice_intro/issues/1#issuecomment-619926939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBHGHOPIPBXAOW75LHSCMTROVVDNANCNFSM4MR2MCBA .

johnareid54 commented 4 years ago

Thanks a lot better, but the landscape needs more design..

image