search

EthoML / VAME

Variational Animal Motion Embedding - A tool for time series embedding and clustering
https://ethoml.github.io/VAME/
GNU General Public License v3.0
2 stars 0 forks source link

Tests #12

Closed vinicvaz closed 1 month ago

vinicvaz commented 1 month ago
bendichter commented 1 month ago

lgtm! Nice use of fixtures. This is mostly just testing that functions run and produce the expected output files. We can create more precise tests once we have codecov in place

luiztauffer commented 1 month ago

I agree we can go about increasing coverage in a next step @vinicvaz

codecov[bot] commented 1 month ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered :open_umbrella:

bendichter commented 1 month ago

@vinicvaz this is great work but I prefer more modular PRs. Could you find a way to break this off and have us review it? Getting a basic test framework in is critical. I think codecov and CD can be in a future PR.

vinicvaz commented 1 month ago

@vinicvaz this is great work but I prefer more modular PRs. Could you find a way to break this off and have us review it? Getting a basic test framework in is critical. I think codecov and CD can be in a future PR.

Sure, I put the workflows in this Draft PR targeting this branch because it has the workflow for testing. Once this PR is merged I update its target.

The current PR (#12) already has the basic tests structure for the main demo pipeline. I didn't finish the post processing steps basic tests because I was not able to fix the bug described here yet.

Do you think we can review it to merge or should we finish the post processing steps before?