search

EthoML / VAME

Variational Animal Motion Embedding - A tool for time series embedding and clustering
https://ethoml.github.io/VAME/
GNU General Public License v3.0
2 stars 0 forks source link

optimize imports #40

Closed bendichter closed 1 week ago

bendichter commented 1 week ago

optimize imports and modify whitespace to adhere to PEP8

vinicvaz commented 1 week ago

@bendichter Do you think we should put a linter / formater on the project? I can setup it and save the configuration on pyproject.toml file. Besiddes that, there are few conflicts between last dev version and this branch. I was not able to commit directly to this branch because you are using a fork so I created a PR to your fork and then we can merge from here. I can also create a new branch in ethoml repo with your changes if you prefer.

bendichter commented 1 week ago

@vinicvaz I would recommend black and isort implemented as a pre-commit similar to https://github.com/catalystneuro/neuroconv/blob/main/.pre-commit-config.yaml.

We use https://pre-commit.ci/, which runs these on the GitHub side. That's nice because then users don't have to worry about installing and setting up pre-commit on their own computers.

Make sure you do that after a big merge as it will cause many merge conflicts with any open PR.