search

EtiamNullam / Etiam-ONI-Modpack

A bunch of mods made for Klei's Oxygen Not Included.
28 stars 10 forks source link

Adds reasonable defaults for Cobalt. #29

Open MicahZoltu opened 1 year ago

MicahZoltu commented 1 year ago

I tried to roughly match the color of the in-game icon for these, but I am far from an expert at this sort of thing so I would be happy to take someone else's colors!

EtiamNullam commented 1 year ago

It looks great! It fits very nicely to the game.

image

People usually prefer bright colors in their creations, so for the custom colors defined in ElementColors.json it's better use bright colors, if possible, while still giving an obvious hint at a glance.

I hope the fact that colors are reflected immediately in-game as you change the config made it easy and enjoyable for you!

Let me know what is your opinion. Thank you very much for your contribution. I really appreciate it!

MicahZoltu commented 1 year ago

I hope the fact that colors are reflected immediately in-game as you change the config made it easy and enjoyable for you!

Definitely! This made it quite easy to narrow down on a "reasonable" color just by test-and-check.

I would be very happy to change the colors to something better, my problem is that my eye for color is absolutely terrible. I fiddled around with the colors for a bit and this is the best I could do, but I recognize that it isn't particularly great. I wish the Cobalt Ore was a bit more "blue" and less "grey", and I wish the Cobalt was a bit more "bright pastel blue" but I couldn't figure out how to make that happen so I settled on what is here.

If someone can suggest some better colors I would be happy to update this PR with them!

EtiamNullam commented 1 year ago

I see you've used DarkMode for Cobaltite, it's hard to achieve bright color with it, but I'm sure you did not use it blindly, it has some caveats. Most notably the color is applied a bit differently for tiles than buildings.

Go on if you still want to fiddle with the color a bit, otherwise let's release the change for users to enjoy.

We can always improve it further later on!

MicahZoltu commented 1 year ago

I have been playing with these colors for a while and I'm satisfied enough with them so I probably won't make any additional updates. I would happily accept changes from someone else, but I suggest we merge this and then let someone submit a PR to improve on it.

MicahZoltu commented 10 months ago

Getting back into the game and immediately noticed that cobalt color was off, and remembered opening this PR to fix it long ago. Any chance of this getting merged?