search

EtienneAb3d / WhisperHallu

Experimental code: sound file preprocessing to optimize Whisper transcriptions without hallucinated texts
264 stars 22 forks source link

made some improve #13

Open ILG2021 opened 1 year ago

ILG2021 commented 1 year ago
  1. add main.py for the example
  2. add support for chinese
  3. add support custom faster whisper model
EtienneAb3d commented 1 year ago

@ILG2021 Thanks ! With a lot of not significant differences (spaces), it's hard to figure out what were exactly the pertinent parts of your modifications. I think I will try to adapt the main code according to what I think is your change propositions, rather than making a direct automatic fuse.

ILG2021 commented 1 year ago

@ILG2021 Thanks ! With a lot of not significant differences (spaces), it's hard to figure out what were exactly the pertinent parts of your modifications. I think I will try to adapt the main code according to what I think is your change propositions, rather than making a direct automatic fuse.

Sorry, I use pycharm. And habitually formatted the code.

ILG2021 commented 1 year ago

Can you use pycharm? so it will recognize changes quickly.

EtienneAb3d commented 1 year ago

Can you use pycharm? so it will recognize changes quickly.

I will study your proposition, but, on the principle, it's rather up to you to ensure your PR only shows significant differences with the reference code. Otherwise, it will be hard to deal with all specific developer tools each time there is a new contributor. ;-)

HanClinto commented 1 year ago

@ILG2021 Thanks ! With a lot of not significant differences (spaces), it's hard to figure out what were exactly the pertinent parts of your modifications. I think I will try to adapt the main code according to what I think is your change propositions, rather than making a direct automatic fuse.

Sorry, I use pycharm. And habitually formatted the code.

In the future, if you would like to make large formats in a PR like this, please put all formatting changes into one commit separate from any functional changes in another commit. This way, we can clearly see what changed without needing to install new tools.

Commits should only ever do one of the following at a time:

Cleanup Refactor Change functionality

Do not mix categories in the same commit -- otherwise it is adds difficulty to review.