EtienneCmb / visbrain

A multi-purpose GPU-accelerated open-source suite for brain data visualization
http://visbrain.org
Other
242 stars 65 forks source link

Accept different decimal separator #30

Closed skjerns closed 5 years ago

skjerns commented 5 years ago

In some countries (i.e. France and Germany), the comma is the decimal separator. However, in most countries, a dot indicates the decimal.

Right now, my dots are just ignored and I create a filter of 8 Hz instead of '0.8 Hz'.

What would be the best way to implement such options system wide? If you point me towards a good entry point I can see if I can implement it.

EtienneCmb commented 5 years ago

hi @skjerns

I think this is a minor issue, even if I understand your point. This might be changed from the Qt designer

skjerns commented 5 years ago

The NUM-pad decimal separator will output a different character depending on the language setting (. or ,). Qt only accepts a , and ignores the .. This makes the NUM-pad unusable for visbrain if using a dot-decimal setting.

I googled a bit and it indeed seems to be a common problem with Qt.

I agree that it's a minor issue.