EtienneDx / git-mentor

A git server with built-in tools for teaching programming
MIT License
2 stars 0 forks source link

Create database crate #3

Closed EtienneDx closed 6 months ago

EtienneDx commented 9 months ago

Add a PostgreSQL database connection to the gmt-server.

The connection should use an ORM to facilitate the access to the data.

Here's an overview of the data, which should still be refined:

pub struct User {
  id: UUID,
  username: String,
  pubkey: Vec<String>,
  repositories: Vec<Repository>,
}

pub enum RepoType {
  Default,
  CI,
}

pub struct Repository {
  name: String,// Unique name
  repo_type: RepoType,
  owner: User,
  assignment: Option<Assignment>,// Only for student repositories. base and test repositories aren't considered "part" of an assignment
}

pub struct Group {
  teacher: User,
  students: Vec<User>,
}

pub struct Assignment {
  group: Group,
  base_repo: Repository,
  test_repo: Repository,
  correction_repo: Option<Repository>,
}

pub enum CommentType {
  Default,
  Response(Comment),
  Line(String),
}

pub enum CommentAuthor {
  User(User),
  Automated,
}

pub struct Comment {
  repository: Repository,
  commit_hash: String,
  comment_type: CommentType,
  message: String,
  author: CommentAuthor,
  date: Date,
}

This database will be reused by multiple services, and should therefore live in a separate crate. This crate will then be included in the target services.

EtienneDx commented 9 months ago

Looking further into the possibilities, a possible rust orm is diesel. For further coherence between the projects, the structures of the database can be defined directly in rust, while the apis can be defined in protobuf to allow the typescript project to know what it queries.

While it would be possible to define the database directly in protobuf, it would also expose some data or schema that should remain confidential, thus I think we should maintain it separate, even though it means having some redundancy between protobuf and rust.

EtienneDx commented 9 months ago

Regarding the discussed status from CI, I think we need to add another entity:

enum Status {
  Success,
  Pending,
  Cancelled,
  Failed(String),
}

struct CiRun {
  repository: Repository,
  commit: String,
  status: Status,
}
Marin-de-Drouas commented 9 months ago

yes and add email to user!

Marin-de-Drouas commented 9 months ago

Relational database drawio (1) Is that what we want?

EtienneDx commented 9 months ago

Overall looks like it yeah, things might somehow evolve later on but for now looks good

Lerri-Cofannos commented 9 months ago

Can we change the names of Group and Group Student to make it clearer? I am not sure to see the difference... Moreover, we should add an image somewhere in there for profile pictures! Three options:

Lerri-Cofannos commented 9 months ago

Are the creation dates of each entry managed automatically? This will be useful for the displays. How will the content of a repo be managed? commits, folders, etc.

EtienneDx commented 9 months ago

Repos are managed via file system directly (git bare repos), so the database only holds the metadata. This means a s**t-ton of weird APIs to get the data. Hopefully there'll be an easy and clean way to do it but most likely it'll be a pain ^^'

Regarding the images, I think we should go with an optional url field. In case the field is empty, we can use Jdenticon or another lib to generate default ones on the go. Long term we'll add image uploading to an s3 bucket.

For the date stuff, I guess we insert it within the APIs?

Marin-de-Drouas commented 9 months ago

Can we change the names of Group and Group Student to make it clearer? I am not sure to see the difference... Moreover, we should add an image somewhere in there for profile pictures! Three options:

  • have a field for a png for each user (heavy weaponry option)
  • have a table with default images and the users reference the one they want (possibility to have quite a few images, but difficult for custom ones)
  • same thing but have the default images stored in the frontend (it is better to limit the number of images for performance issues, impossible to have custom ones)
EtienneDx commented 9 months ago
Marin-de-Drouas commented 9 months ago

Database is ready, is there some functions we need to implement?

Marin-de-Drouas commented 9 months ago

TODO: Unit tests with independant test database (CRUD + JOIN)

Marin-de-Drouas commented 9 months ago

I have a test environnent and a first test but i can't connect to the database "Cannot connect to postgres database.: BadConnection("connection to server at \"localhost\" (::1), port 5432 failed: FATAL: authentification par mot de passe �chou�e pour l'utilisateur � admin_user �\n")". I don't know why because password is right so i might need some help with that.

EtienneDx commented 7 months ago

Taking over with #29

EtienneDx commented 6 months ago

Closed with #29