EtienneLamoureux / TQVaultAE

Extra bank space for Titan Quest Anniversary Edition
MIT License
288 stars 62 forks source link

Fix issue with certain modded items #347

Closed ghost closed 4 years ago

ghost commented 4 years ago

I had reported an issue a while ago about a modded character that would make Vault crash because it used a skill that started with "Temp"; a keyword in programmation, I believe.

I've found something similar : loading a character that has (in its inventory or storage area) a modded item that starts with "For"; another keyword in programmation (which makes me believe that's the issue.)

The resulting error message goes like this. Capture

When ignored, the container will be unusable or very buggy. It displays wide boxes with a red X inside that cover the affected area.

ejfudd commented 4 years ago

The previous issue was related to the skill name starting with the same text as one of the item tags. This looks a bit different in that it's complaining about parenthesis in the expression parser during the calculation of the dynamic requirements. It would be helpful for you to specify which particular mod you are using and to upload the character file which is causing the issue.

ghost commented 4 years ago

The mod used is Shadow Champions on its latest version. https://steamcommunity.com/sharedfiles/filedetails/?id=1949340853

The character : https://mega.nz/file/0Is1HThZ#lSnH85w5InuaM42PczvYiogxLXz8D_aTJEPLjOFs0Cc The item in cause is the leg armor called "Forgotten Boots". It's in the first additional bag of its inventory.

hguy commented 4 years ago

This mod have "warning and notices" very well done. They know already that it may have problems with TQVault. image

image

hguy commented 4 years ago

The math expression is coming from de mod database so this is not a TQVault issue but a mod issue.

ItemId : records\customitems\epics\e_forgottenboots.dbr

image

ghost commented 4 years ago

Oh, I would've never figured it out! Thank you for your help :)