EtienneLamoureux / TQVaultAE

Extra bank space for Titan Quest Anniversary Edition
MIT License
285 stars 62 forks source link

TQ Vault 3.8.0.0 mastery reset bug #400

Closed BuggedCharacter closed 2 years ago

BuggedCharacter commented 2 years ago

Hello everyone,

First of all I am no coder, I simply want to report a bug I found on the mastery reset feature of TQ Vault 3.8.0.0. and expose my character problem in case someone can help.

If you have points into the Atlantis new skills, the mastery reset feature cannot remove these skill points properly, and it will only give you back the points to allocate that were anywhere else besides these new skills.

How to show this?

Create an accomplished hero so that you have 124 skill points to allocate right away. Dump 40 skill points into the (left tab) mastery (let's say storm), filling up the bar on the left. Now dump 6 skill points in "Lightning Dash". At this stage you should have 78 skill points available.

Now for our right tab mastery, let's chose let's choose earth mastery. Let's remember this: "Storm on the left, Earth on the right"...(just in case) Let's fill up the earth mastery bar on the left with 40 points and then lets dump 12 points into "Meteor Rain" and then 8 points into "Fire Nova". Now you should have 18 skill points available. Once more ((just in case), remember: "Storm on the left, Earth on the right".

Now let's save and exit the game.

Let's open the TQ Vault 3.8.0.0 and select the accomplished hero character we have just created. On the character equipment tab we press the button "edit" to bring up the character editor window. Now in the character editor window we can see that in masteries it says we have 1 storm skill (which should be "Lightning Dash" at level 6), but in the earth mastery it also says we have only 1 skill (however this should say 2 skills because we have dumped 12 points in "Meteor Rain" and 8 points in "Fire Nova"). But this is not the real issue!!!!

Still on the Character Editor window, now we press the button "Reset Masteries" and then "Exit" to close the TQ Vault 3.8.0.0 and then we run the game and we won't have 124 skill points correctly available! This is the real issue!!!

So let's run the game and see our character now. We can reallocate skill points into different masteries but as soon as we get into one to start dumping the points we realise that we don't have 124 skill points available. Instead, we have 98. Why? because we have allocated: -6 points into "Lightning Dash" -12 points in "Meteor Rain" -8 points in "Fire Nova" These 3 skills contain a total of 6+12+8=26 skill points. 26 Skill points is exactly the difference from 124-98=26. The TQ Vault cannot effectively remove these skill points from these Atlantis skills. We can see the skills are not removed because if we "right click" on the skill bar in any "quick slot" we can see it still displays the option of assigning any of those skills to the skill bar.

Now, remember "Storm on the left, Earth on the right". Let's refill both masteries with 40 points each by choosing "Storm on the left mastery tab, Earth on the right mastery". Before start dumping the points we can already see that the skills "Lightning Dash", "Meteor Rain" and "Fire Nova" are already highlighted instead of greyed out. Once we fill up 40 points into each mastery bar we can see that those 3 skills ("Lightning Dash", "Meteor Rain" and "Fire Nova") are already maxed, because the points were never removed from them.

The issue with this is that if you chose to replace any of the masteries by any other, you will lose those skill points forever. This means that if we now replace the "storm mastery" with any mastery (that is not earth mastery) we loose those 6 skill points forever (in "Lightning Dash"). And if we replace the "earth mastery" for any mastery (that is not storm mastery) we lose those 20 skill points too (12 in "Meteor Rain" plus 8 in "Fire Nova"). This is the issue!

If the TQ Vault cannot be fixed to work with Atlantis skills, then I guess a warning window can be added when we press "Reset Masteries" to warn the user that the Atlantis skills should be removed first by the Mystic NPC in game!

I lost 5 skill points on my level 60 character due to this bug and now I was trying to edit the safe file in order to get those 5 skill points back, but so far no editor seems to be working. I have tried the "Enable Leveling" function in the "Character Editor" window on the TQVault 3.8.0.0 to recover the skill points. I messed around with it back and forward and I ended up with 62 extra attribute points and I also have no idea how it happened.

I tried to use TQDefiler, but with no success. It seems that it is not compatible with the GOG version of the game. It loads my character savefile, but it seems to not be able to make any changes on it. I have tried GDDefiler and it also does not work. Been looking all over the internet for a solution and I can't seem to find anything.

Anyway, thank you for reading. Cheers

BuggedCharacter commented 2 years ago

Edit: I have solved my problem with a Hex editor and changed 2 values relative to the skill and attribute points to the right numbers.

Cheers