search

EtienneLamoureux / TQVaultAE

Extra bank space for Titan Quest Anniversary Edition
MIT License
279 stars 62 forks source link

Added money editing options #430

Closed mimic2300 closed 2 years ago

mimic2300 commented 2 years ago

I think it would be good to be able to edit money as well :-) A localization for all languages for the CEMoney key has also been added.

image

Damn... I accidentally committed localized comments in Resources.Designer.cs (I don't know how I did it) so you can ignore this file and add it manually

        public static string CEMoney {
            get {
                return ResourceManager.GetString("CEMoney", resourceCulture);
            }
        }
hguy commented 2 years ago

Visual Studio 20XX regen automaticaly Resources.Designer.cs each time you update Resources.resx. All *.Designer.cs should not be edited manually (except at merge time maybe).

mimic2300 commented 2 years ago

Visual Studio 20XX regen automaticaly Resources.Designer.cs each time you update Resources.resx. All *.Designer.cs should not be edited manually (except at merge time maybe).

So should I fix it or can you handle it? I would have to create a new PR for that.

hguy commented 2 years ago

Visual Studio 20XX regen automaticaly Resources.Designer.cs each time you update Resources.resx. All *.Designer.cs should not be edited manually (except at merge time maybe).

So should I fix it or can you handle it? I would have to create a new PR for that.

I don't understand why you can't update your own PR ? Push a commit that fix your branch mimic2300:feature/gold_edit.

mimic2300 commented 2 years ago

Conflict fixed

mimic2300 commented 2 years ago

Moved to: https://github.com/EtienneLamoureux/TQVaultAE/pull/444