search

EtienneLamoureux / sc-trade-tools

Issues repository for SC Trade Tools
http://sc-trade.tools
23 stars 4 forks source link

Having more available cash should not cause you to net less on a trade run. #119

Open Tahaan opened 1 year ago

Tahaan commented 1 year ago

Describe the bug

The algorithm does not always pick the most optimal trade route.

To Reproduce

Go to "En Route". Input parameters: Ship = Conny Andromeda Origin = The Orphanage Destination = Brio's Investment = 600119 (exactly this amount of aUEC). Max Stops: 5 Max detour: 25% Run it and record the result.

Now update and change ONLY the starting investment - increase the amount by 1 aUEC. Run it again and record the result, and compare.

Expected behaviour

If you have more cash to invest, you make more proffit

Screenshots

Compare the results from these two links. The only difference in input parameters is the first starts with 600119 aUEC and the second starts with 600120 aUEC - eg one aUEC more.

https://sc-trade.tools/en-route?q=%257B%2522ship%2522:%2522Constellation%2520Andromeda%2522,%2522investment%2522:600119,%2522origin%2522:%2522Stanton%2520%253E%2520ArcCorp%2520%253E%2520Lyria%2520%253E%2520The%2520Orphanage%2522,%2522destination%2522:%2522Stanton%2520%253E%2520Crusader%2520%253E%2520Daymar%2520%253E%2520Brio%2527s%2520Breaker%2520Yard%2522,%2522locationNames%2522:%255B%255D%257D

https://sc-trade.tools/en-route?q=%257B%2522ship%2522:%2522Constellation%2520Andromeda%2522,%2522investment%2522:600120,%2522origin%2522:%2522Stanton%2520%253E%2520ArcCorp%2520%253E%2520Lyria%2520%253E%2520The%2520Orphanage%2522,%2522destination%2522:%2522Stanton%2520%253E%2520Crusader%2520%253E%2520Daymar%2520%253E%2520Brio%2527s%2520Breaker%2520Yard%2522,%2522locationNames%2522:%255B%255D%257D

EtienneLamoureux commented 1 year ago

Thanks for that, I'll looks into it.