Mac OSX fixes for `sed` extended regular expressions and and `expr` parsing numbers with whitespace

EtiennePerot / parcimonie.sh

Refresh your GnuPG keyring without disclosing your whole contact list to the world

Do What The F*ck You Want To Public License

225 stars 15 forks source link

Mac OSX fixes for `sed` extended regular expressions and and `expr` parsing numbers with whitespace #2

Closed joelpurra closed 10 years ago

joelpurra commented 10 years ago

In reference to issue #1.

The sed command is tested for the -r flag, and uses the -E flag as a fallback.
Numbers from external commands are stripped from anything non-digit, before being passed into expr.

Tested on a non-pristine Mac OSX 10.9 Mavericks system, with enough non-system (GNU etcetera) software to possibly affect the actual Mac OSX portability of this script. Try it out!

EtiennePerot commented 10 years ago

with enough custom software to possibly affect the actual Max OSX portability of this script

Can you try it on an unmodified OS X installation (or make it run with the stock binaries somehow) to make sure this helps other OS X users?

joelpurra commented 10 years ago

@EtiennePerot: unfortunately, I don't have any clean installations available. Someone else might be able to test? I'll ask people on IRC.

ChrisMacNaughton commented 10 years ago

I just built a clean Mac VM and the changes run just fine

joelpurra commented 10 years ago

@ChrisMacNaughton: good news - thanks for making the effort to set up a new system for testing!

EtiennePerot commented 10 years ago

Thanks Chris!