Sed flag test error output visible on Mac OS X

EtiennePerot / parcimonie.sh

Refresh your GnuPG keyring without disclosing your whole contact list to the world

Do What The F*ck You Want To Public License

225 stars 15 forks source link

Sed flag test error output visible on Mac OS X #3

Closed joelpurra closed 10 years ago

joelpurra commented 10 years ago

In EtiennePerot/parcimonie.sh@7fff20a, the sed regexp flag test generates an error message on Mac OS X.

$ ./parcimonie.sh
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
> Sleeping 12840 seconds before refreshing key ...

It would be better to hide the error output, as it does not affect running the script.

EtiennePerot commented 10 years ago

The joys of not testing on all platforms striking for the second time :)

joelpurra commented 10 years ago

@EtiennePerot: just wait until others with more esoteric systems start using this =)

Tested, works - thanks!

EtiennePerot commented 10 years ago

By the way, I hope the output you posted wasn't directly copy pasted:

> Sleeping 12840 seconds before refreshing key ...

This should say [...] before refreshing key SUPERLONGFINGERPRINTGOESHERE.... Did you manually remove it from the bug report for privacy or is it actually missing from the output?

joelpurra commented 10 years ago

@EtiennePerot: I removed it manually, of course - it's a privacy tool, isn't it? ;) Could have, as I've done previously, replaced it with my own key fingerprint.

Had parcimonie.sh running since implementing the Mac OS X fixes, and it seems to work as intended!