search

EtlamGit / owncloud_button

ownCloud log in screen with separate button
GNU Affero General Public License v3.0
1 stars 0 forks source link

Discussion Board #1

Open EtlamGit opened 8 years ago

EtlamGit commented 8 years ago

This special issue number is reserved for general discussion. If you would like to give feedback, ask something or just state that you are using the files provided here, this is the right place. If you encounter real problems or bugs, open a new issue.

oparoz commented 8 years ago

I like the idea, but it would be more useful as a patch.

Maybe fork recent versions of ownCloud in the repo and keep a PR per patch which would be rebased if needed. That way we could simply fetch the patch and apply it.

EtlamGit commented 8 years ago

Interesting point, will think about it next year. I personally do not like the format of patch files, as they lack enough context to judge if the changes are useful or not. They are better readable for computers than for humans. If I have to judge if some changes are ok, I put the files (or complete folders) in a graphical diff tool to get the complete context of the changes. The patch format would possibly be easier to apply in case the changes are acceptable. A solution would be to have two branches, one with the complete changed files and another one with the patches. It could also be two separate repositories.