eaescob
commented
11 years ago I'm going to try to tackle this but I no longer have OS X. I might need to download/install on a VM. @justfalter do you have time for this?
Closed nieder closed 11 years ago
eaescob
commented
11 years ago I'm going to try to tackle this but I no longer have OS X. I might need to download/install on a VM. @justfalter do you have time for this?
justfalter
commented
11 years ago I'm literally moving to a new house at this very moment. :(
Lemme see if I can scare up someone who has a Mac to help us out.
On Oct 4, 2013, at 10:38 AM, "Emilio A. Escobar" notifications@github.com wrote:
I'm going to try to tackle this but I no longer have OS X. I might need to download/install on a VM. @justfalter do you have time for this?
— Reply to this email directly or view it on GitHub.
eaescob
commented
11 years ago No problem :) I can install a VM or try from my iMac. I might have time on Sunday. Where you moving/going to?
Emilio Escobar / eescobar@gmail.com
On Fri, Oct 4, 2013 at 8:48 AM, Mike Ryan notifications@github.com wrote:
I'm literally moving to a new house at this very moment. :(
Lemme see if I can scare up someone who has a Mac to help us out.
On Oct 4, 2013, at 10:38 AM, "Emilio A. Escobar" < notifications@github.com> wrote:
I'm going to try to tackle this but I no longer have OS X. I might need to download/install on a VM. @justfalter do you have time for this?
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/Ettercap/ettercap/issues/344#issuecomment-25708990 .
justfalter
commented
11 years ago The beautiful suburbs of Chicago :) I've been cooped up in a a 750 sq foot condo for too long. I'm looking forward to having a yard and a grill!
On Oct 4, 2013, at 11:02 AM, "Emilio A. Escobar" notifications@github.com wrote:
No problem :) I can install a VM or try from my iMac. I might have time on Sunday. Where you moving/going to?
Emilio Escobar / eescobar@gmail.com
- Great spirits have always encountered strong oppositions from mediocre minds. -- Einstein
On Fri, Oct 4, 2013 at 8:48 AM, Mike Ryan notifications@github.com wrote:
I'm literally moving to a new house at this very moment. :(
Lemme see if I can scare up someone who has a Mac to help us out.
On Oct 4, 2013, at 10:38 AM, "Emilio A. Escobar" < notifications@github.com> wrote:
I'm going to try to tackle this but I no longer have OS X. I might need to download/install on a VM. @justfalter do you have time for this?
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/Ettercap/ettercap/issues/344#issuecomment-25708990 .
— Reply to this email directly or view it on GitHub.
nosteve
commented
11 years ago Think I found it. Change about 2 months ago that modified some mem usage but only updated ec_linux.c:
https://github.com/AntonioCollarino/ettercap/commit/079ea1682c8ae019bd7742ced349396658e217be
Look for the addition of safe_free_mem. Doesn't exist in ec_darwin.c - also consider other platforms that may be affected.
Gave this a shot in ec_darwin.c and seems to work. Here's where I added his stuff:
...
void disable_ip_forward(void);
static void restore_ip_forward(void);
u_int16 get_iface_mtu(const char *iface);
void safe_free_mem(char **param, int *param_length, char *command); //here
/*******************************************/
...then just added the function as the last one:
void safe_free_mem(char **param, int *param_length, char *command)
{
int k;
SAFE_FREE(command);
for(k= 0; k < (*param_length); ++k)
SAFE_FREE(param[k]);
SAFE_FREE(param);
}
/* EOF */Compiles now, haven't tested it much yet but the binary executes.
eaescob
commented
11 years ago Thanks! Pull request should fix it
ghost
commented
11 years ago @eaescob you were faster than me ;) thank you!
nieder
commented
11 years ago 33ac95f fixes the safe_free_mem failure for me on git-head an 0.8.0.
eaescob
commented
11 years ago Closing
On OS X 10.7 with apple-clang-4.2 or llvm-gcc-4.2 (Xcode 4.6.3), the ettercap-0.8.0 build fails with this error: