EttusResearch / uhd

The USRP™ Hardware Driver Repository
http://uhd.ettus.com
Other
946 stars 646 forks source link

Should `_ctrl_recv_cb` match management packets? #651

Closed johnwstanford closed 1 year ago

johnwstanford commented 1 year ago

The comment on line 33 says that the callback should match management and control packets, but inside the definition on line 64, it only matches control packets.

https://github.com/EttusResearch/uhd/blob/dfccfcefe555cb10d1d419e5d7fb9b7d52e43dfe/host/lib/rfnoc/chdr_ctrl_xport.cpp#L34

johnwstanford commented 1 year ago

Never mind, I see now that there's _mgmt_recv_cb for that. I was just confused by the wording of the comment. It made it sound like there would be one receive client for both.