nzqo commented 1 year ago

Pull Request Details

Description

These changes allow to use the tx_samples_from_file example with a specified number of repetitions using the n-repeat option.

I didn't know whether breaking compatibility was okay, so I did not. Instead, the --repeat option overwrites the new flag and still causes transmission until a SIGINT is received. I did, however, change that signal handling to be conformal by using the appropriate sig_atomic_t flag type.

On the way, I made some minor formatting change, got rid of a few annoying compiler warnings and improved some CMake stuff. Specifically:

install_name wasnt manually set in CMake, which caused a warning in newer CMake versions due to breaking changes
Version range in DPDK find package module wasnt handled properly. Another warning that was easy to fix
Use of sprintf which I simply substituted with snprintf
A missing virtual destructor which could potentially have lead to memory issues

Which devices/areas does this affect?

Affects host uhd lib (no functional changes) and the tx_samples_from_file example (convenience feature).

Testing Done

Present tests pass. I dont think there are tests for the examples though. Since the changes are mostly minor I dont think new tests are required.

As for the example itself, I ran it with a few different options (repeat, n-repeat, both) to confirm that it doesnt crash or anything.

Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project. See CODING.md.
[ ] I have updated the documentation accordingly.
[x] ~I have added tests to cover my changes, and~ all previous tests pass.
[ ] I have checked all compat numbers if they need updating (FPGA compat, MPM compat, noc_shell, specific RFNoC block, ...)

Additional notes

It might make sense to bring in codestyle for CMake files as well (and e.g. enforce it using cmake-format). Also, I didnt want to touch it, but some of the boost filesystem stuff is deprecated in favor of C++17's filesystem. I was considering abstracting the relevant functions away and switching between the two depending on the supported standard of the local compiler, but that was too much hassle to do for now.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

nzqo commented 1 year ago

I have read the CLA Document and I hereby sign the CLA