search

EttusResearch / uhd

The USRP™ Hardware Driver Repository
http://uhd.ettus.com
Other
942 stars 645 forks source link

Should `_fb_after_divider` be a `bool`? #686

Closed johnwstanford closed 8 months ago

johnwstanford commented 1 year ago

It looks like _fb_after_divider is initialized and used as a bool, but declared here as a double. Should it be declared as a bool?

https://github.com/EttusResearch/uhd/blob/0e50a37b5ec6039ed4e8947421dd333047e24408/host/lib/include/uhdlib/usrp/common/adf435x.hpp#L558C12-L558C29

mbr0wn commented 8 months ago

It should, and as it happens, this was fixed as part of d80d56114a5eb15b84.