EttusResearch / uhd

The USRP™ Hardware Driver Repository

http://uhd.ettus.com

Other

942 stars 645 forks source link

Fix build with clang + libc++ runtime #690

Closed kraj closed 12 months ago

kraj commented 1 year ago

Pull Request Details

Description

Related Issue

Which devices/areas does this affect?

Testing Done

Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project. See CODING.md.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes, and all previous tests pass.
[ ] I have checked all compat numbers if they need updating (FPGA compat, MPM compat, noc_shell, specific RFNoC block, ...)

mbr0wn commented 12 months ago

@kraj, thanks for the find and reporting it. One of your commits was a dupe of https://github.com/EttusResearch/uhd/pull/681, which is already merged. For the time spec conversion, you are right that this is problematic, but your solution is also not guaranteed to have the right result.

mbr0wn commented 12 months ago

I have triggered a conversation internally to provide the correct patch.