Fix binary file reading in bin_to_coe.py

XhovaniM8 commented 3 months ago

Description

I have made the necessary changes to the bin_to_coe.py script to fix the issue of reading the binary file without the 'rb' flag, which caused decoding errors. This change ensures that the COE file is generated correctly from the binary file.

Related Issue

Fixes #760

Which devices/areas does this affect?

This affects the X300 series USRP devices. The change specifically impacts the process of generating COE files from binary files during firmware builds.

Testing Done

I have run the modified script in the provided docker environment and confirmed that the COE file is generated successfully without any errors. The testing was done in a controlled environment using the Ubuntu 22.04 docker image as described in the issue. All previous tests passed successfully after the modification.

Checklist

[X] I have read the CONTRIBUTING document.
[X] My code follows the code style of this project. See CODING.md.
[X] I have updated the documentation accordingly.
[X] I have added tests to cover my changes, and all previous tests pass.
[X] I have checked all compat numbers if they need updating (FPGA compat, MPM compat, noc_shell, specific RFNoC block, ...)

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

XhovaniM8 commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

XhovaniM8 commented 3 months ago

recheck

mbr0wn commented 3 months ago

@XhovaniM8 we have some issues with our CLA checker. Your fix requires some minor mods, but we'll handle that and merge your PR fairly soon. Many thanks!

EttusResearch / uhd