search

EttusResearch / uhd

The USRP™ Hardware Driver Repository
http://uhd.ettus.com
Other
1k stars 666 forks source link

Missing comma in generated noc_shell file causes error #780

Closed ejesse-nd closed 2 months ago

ejesse-nd commented 3 months ago

Issue Description

I used a command similar to the one in Getting Started with RFNoC in UHD 4.0: Generating Your Block Using the ModTool, namely python3 <repo>/host/utils/rfnoc_blocktool/rfnoc_create_verilog.py -c ~/rfnoc-demo/blocks/demo.yml -d ~/rfnoc-demo/fpga/rfnoc_block_demo When I try to run the testbench on the block, I receive the following error: ERROR: [VRFC 10-2063] Module <noc_shell_newblock> not found while processing module instance <noc_shell_newblock_i> Digging into the issue, it turns out that there was a comma missing in the noc_shell_newblock definition inside the noc_shell_newblock.v file generated by the tool. The missing comma should be right before the RFNoC Backend Interface wires.

Setup Details

UHD-4.7 (a5ed187) I had issues with both the axis_data and the axis_pyld_ctxt interfaces.

Additional Information

This was a bit of a headache to figure out. For a long time I thought "not found" meant an issue with my CMake/Make setup such that it could not find the noc_shell_newblock.v file for some reason.

mbr0wn commented 2 months ago

@ejesse-nd Thanks for the report. We can reproduce the issue and will have a fix up soon.